maf_parse: Allow maf blocks with duplicate srcNames.#83
Open
gordoni wants to merge 1 commit intoCshlSiepelLab:masterfrom
Open
maf_parse: Allow maf blocks with duplicate srcNames.#83gordoni wants to merge 1 commit intoCshlSiepelLab:masterfrom
gordoni wants to merge 1 commit intoCshlSiepelLab:masterfrom
Conversation
This happens in large alignments, such as in the Zoonomia alignments of 241 placental mammals. There is a potential problem in allowing duplicate srcNames, if the srcName is also in a list of sequences to include/exclude, reorder, or mask, then this might not be handled correctly. However, this problem also exists when just the species name component appears more than once, and is also in a list of sequences to include/exclude, reorder, or mask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens in large alignments, such as in the Zoonomia alignments of 241 placental mammals.
There is a potential problem in allowing duplicate srcNames, if the srcName is also in a list of sequences to include/exclude, reorder, or mask, then this might not be handled correctly. However, this problem also exists when just the species name component appears more than once, and is also in a list of sequences to include/exclude, reorder, or mask.