storage: check alt blocks when handling missing tx request in DB#599
Open
redsh4de wants to merge 1 commit intoCuprate:mainfrom
Open
storage: check alt blocks when handling missing tx request in DB#599redsh4de wants to merge 1 commit intoCuprate:mainfrom
redsh4de wants to merge 1 commit intoCuprate:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Support alt blocks in
TxsInBlockCloses #580
Why
txs_in_blockonly searches the main chain at the moment. A peer can request missing transactions for a block that is on an alt chain - either from a reorg or because Cuprate broadcasts alt blocks as of #577Where
storage/blockchainHow
get_alt_block_blob_with_tx_hasheshelper that retrieves an alt block's blob and tx hashestxs_in_blockto try the main chain first, then fall back to alt-chain tables onKeyNotFoundalt_transaction_blobsfirst, then fall back to checking main-chain blobs.