Skip to content

Populate url when processing license expressions#999

Open
giovanni-bozzano wants to merge 1 commit into
CycloneDX:masterfrom
giovanni-bozzano:master
Open

Populate url when processing license expressions#999
giovanni-bozzano wants to merge 1 commit into
CycloneDX:masterfrom
giovanni-bozzano:master

Conversation

@giovanni-bozzano

Copy link
Copy Markdown

When a NuGet package defines its license by expression type and then provides the licenseUrl, the latter is missed during the collection.

This change applies the optional licenseUrl to all licenses processed from the expression, in order not to lose the information.

@giovanni-bozzano giovanni-bozzano requested a review from a team as a code owner December 16, 2025 09:53
Signed-off-by: Giovanni Bozzano <giovanni.bozzano@traceone.com>
@Falco20019

Falco20019 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

We would need exactly this. Could this be merged as it's just a one-line change? Otherwise, it's not enough to for MIT and APL2 licensing and we would still need to include the URL or text somewhere else...

@Falco20019

Falco20019 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@mtsfoni In #1076 you wrote that expression + licenseUrl is invalid. That's correct, but that's also not what's happening in this PR. This PR uses the license metadata to get the URL, not the nupkg itself. For nuget.org this will contain the URL as https://licenses.nuget.org/<expression>.

We now went on to use the Spdx3 package to resolve the ID to license texts instead of hoping that it's set by the SBOM. But for customers this would still be a benefit to know where the license text can be fetched from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants