feat: Add BatchNanMin, BatchNanMax, and BatchNanPeakToPeak#11
Merged
Conversation
This commit introduces three new NaN-aware statistical classes: - `BatchNanMin`: for calculating the minimum of batches of data, ignoring NaNs. - `BatchNanMax`: for calculating the maximum of batches of data, ignoring NaNs. - `BatchNanPeakToPeak`: for calculating the peak-to-peak (max - min) of batches of data, ignoring NaNs. The implementation follows the existing structure of the library. `BatchNanMin` and `BatchNanMax` are implemented similarly to their non-NaN counterparts, but using `np.nanmin` and `np.nanmax` respectively. `BatchNanPeakToPeak` is implemented by composing `BatchNanMin` and `BatchNanMax`. This commit also includes: - Unit tests for the new classes. - Updates to the documentation and README to include the new classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
BatchNanMin,BatchNanMax, andBatchNanPeakToPeakto handle batch statistical calculations while ignoring NaN values.