perf: avoid post-pass column reconstruction in NaN preprocessing #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the preprocessing step used to build the NaN coordinate mapping in OptiMask.
Instead of reconstructing cols_with_nan at the end with np.flatnonzero(...) and an additional reordering pass, the branch records NaN column indices directly
during the main scan. That removes extra array work after preprocessing while preserving the existing output shape and semantics.
What Changed
Why
The previous implementation did the column discovery twice:
This change keeps the same behavior but avoids that post-processing step, which should reduce preprocessing overhead on inputs with missing values.
Notes