Skip to content

Replace FluentAssertions to Shouldly#105

Merged
neuecc merged 5 commits into
Cysharp:masterfrom
Y-YoL:replace-test
Jun 12, 2025
Merged

Replace FluentAssertions to Shouldly#105
neuecc merged 5 commits into
Cysharp:masterfrom
Y-YoL:replace-test

Conversation

@Y-YoL
Copy link
Copy Markdown
Contributor

@Y-YoL Y-YoL commented Jan 26, 2025

see Cysharp/ConsoleAppFramework#158

Added ToArray because some tests were failing when using ShouldBeEquivalentTo.

Y-YoL added 4 commits January 26, 2025 20:58
Shouldly.ShouldAssertException : Comparing object equivalence
Expected value to be System.Int32[]
but was System.Linq.Enumerable+OrderedIterator`2[System.Int32,System.Int32]
@Y-YoL
Copy link
Copy Markdown
Contributor Author

Y-YoL commented Jan 26, 2025

Maybe ShouldBeEquivalentTo could be replaced with ShouldBe, but I'm not sure how that works so I'm leaving it as it is.

@Y-YoL Y-YoL marked this pull request as ready for review January 26, 2025 12:32
@neuecc
Copy link
Copy Markdown
Member

neuecc commented Jun 12, 2025

sorry for delayed response and thanks to nice migration!

@neuecc neuecc merged commit 27aab45 into Cysharp:master Jun 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants