Skip to content

feat: enhance project metadata and add version validation script#1

Closed
Czarnak wants to merge 1 commit into
mainfrom
chore/pypi-release-automation
Closed

feat: enhance project metadata and add version validation script#1
Czarnak wants to merge 1 commit into
mainfrom
chore/pypi-release-automation

Conversation

@Czarnak

@Czarnak Czarnak commented Jun 3, 2026

Copy link
Copy Markdown
Owner
  • Updated pyproject.toml to include authors, keywords, classifiers, and project URLs.
  • Expanded development dependencies to include build, pytest-cov, and twine.
  • Added a new script check_release_version.py to validate that release tags match package versions defined in pyproject.toml and __init__.py.
  • Created tests for the version validation script to ensure correct functionality and error handling.

- Updated `pyproject.toml` to include authors, keywords, classifiers, and project URLs.
- Expanded development dependencies to include `build`, `pytest-cov`, and `twine`.
- Added a new script `check_release_version.py` to validate that release tags match package versions defined in `pyproject.toml` and `__init__.py`.
- Created tests for the version validation script to ensure correct functionality and error handling.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d2e36b7b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
code=$?
if [ "$code" -eq 5 ]; then echo "No tests collected yet — passing scaffold."; exit 0; fi
exit $code
run: pytest -q --cov=simaticml_decoder --cov-report=term-missing --cov-fail-under=80

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid breaking CI with an unreachable coverage gate

In a fresh checkout tests/fixtures/ is gitignored, so the fixture-backed tests skip; I verified the unmodified suite runs as 39 passed, 12 skipped, and a stdlib trace run of those same tests estimates only about 59% source coverage because modules such as parse.py remain mostly unexercised without fixtures. With pytest-cov installed by the workflow, this new --cov-fail-under=80 gate will fail every push/PR before any code can merge (the release workflow uses the same command), unless the threshold is lowered or fixture-free tests are added to reach 80%.

Useful? React with 👍 / 👎.

@Czarnak Czarnak closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant