fix(retrieval): move rag_config import to module top-level#58
Open
D4R102004 wants to merge 1 commit into
Open
Conversation
Replace deferred indirect import via ranking.ranking with direct import from rag.config at module top-level. Same object, no circular imports, consistent with all other modules. Closes #57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move
rag_configimport from insidesearch()function body to module top-level.Why
The deferred import used
ranking.rankingas intermediary to reachrag.config. This adds an unnecessary dependency on the entire ranking module just to get a config object, and hides the dependency inside a function body where it re-executes on every call.Tests
182 passed, 10 failed — all failures are pre-existing in main (test_system.py references stale API).
Closes #57