fix(crawler): create raw directory before writing metadata file#60
Open
D4R102004 wants to merge 1 commit into
Open
fix(crawler): create raw directory before writing metadata file#60D4R102004 wants to merge 1 commit into
D4R102004 wants to merge 1 commit into
Conversation
Add os.makedirs() before opening _metadata.txt to prevent FileNotFoundError when the spider output directory does not exist. Closes #59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
os.makedirs()before opening_metadata.txtinrun_all_crawlers().Why
When a spider's output directory does not exist (e.g.
data/raw/lobsters/), the metadata write fails withFileNotFoundError. This caused Lobsters to report 0 articles even when the crawl succeeded.Tests
21/21 crawler tests passed.
Closes #59