KREAd Contract Upgrade a3p-integration proposal

[Jorge-Lopes]

Description

This pull request introduces a new a3p-integration proposal (k:kread) aimed at verifying two key aspects:

• Ensuring that modifications to the KREAd contract for handling subscriber exits (proposed in PR Enhance KREAd Contract Robustness to Support Upgrades in Zoe #2) effectively address Issue #8714.
• Confirming that user assets remain intact following a contract upgrade.

Solution Overview

After some deliberations on the recommended process for installing the bundles on-chain and determining if the KREAd core-eval upgrade should be included in the chain software upgrade proposal, the proposed solution was to establish an a3p-integration subdirectory (sourced from agoric-sdk) and include a new proposal for KREAd with the corresponding assets.
These assets can be utilized in the Cosgov UI when executing the core-eval proposal on-chain. After the deployment of changes on-chain, the a3p test can be migrated to the agoric-3-proposals repository for broader use.

Testing

To ensure asset integrity during the KREAd contract upgrade and verify that market subscribers survive Zoe upgrades, the following test cases were implemented in kread.test.js and executed during the use phase:

Test Case 1: User Assets Survive KREAd Contract Upgrade

• Alice and Bob mint a Character with the three default items.
• Verify the Character and items are correctly assigned to their wallets.
• Perform the KREAd contract upgrade.
• Confirm the incarnation number increases by 1.
• Ensure the Character and items are still correctly held post-upgrade.

Test Case 2: Market Subscribers Survive Zoe Contract Upgrade

• Alice and Bob Sell their Characters on the market.
• Confirm the Characters are removed from their wallets and listed on the market.
• Perform the Zoe vat upgrade.
• Confirm the incarnation number increases by 1.
• Execute tryExitOffer with Alice's sell offer ID.
• Verify the offer is removed from Alice’s wallet and the Character is correctly returned.
• Ensure Alice’s Character is no longer listed, but Bob’s is still available.
• Purchase Bob’s Character and verify it transfers correctly.

Artifacts

The relevant assets for the KREAd proposal are located at:

• KREAD/agoric/a3p-integration/proposals/k:kread/submission
• KREAD/agoric/a3p-integration/proposals/k:kread/upgrade-kread
• KREAD/agoric/a3p-integration/proposals/k:kread/upgrade-zoe

Note: The upgrade-kread and upgrade-zoe submissions were generated and copied from agoric-sdk/a3p-integration using the build-all-submissions.sh script. As a result, the sdk-generate field in a3p-integration/proposals/k:kread/package.json is intentionally left empty.

Related Issues

closes: Agoric/agoric-sdk#10392
rel: Agoric/agoric-sdk#8714

Checklist

• I have used agoric's linter on my code (What linting configuration should I use for my Agoric contracts? Agoric/agoric-sdk#8274)
• I have added/updated unit tests to cover the changes.
• All existing tests pass.
• The PR title is clear and concise.