Conversation
Keane Fix Audio
DDVD233
reviewed
Sep 9, 2025
| raw_prompt = self.processor.apply_chat_template( | ||
| messages, add_generation_prompt=True, tokenize=False, **self.apply_chat_template_kwargs | ||
| ) | ||
| multi_modal_data = {} |
Owner
There was a problem hiding this comment.
I think self.apply_chat_template_kwargs is passed here. Is there a place where it's not passed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge audio support in. i assume Qwen2_5OmniThinkerForConditionalGeneration is in HF so no need for custom logic; keep some debugging stuff here and there (can remove if needed); there is this video budget change in vision_utils.py , that should be a setting?
in rl_dataset , there's a ton of changes, and i try to respect the new audio support which uses self.modalities . there were some intriguing areas like here where self.apply_chat_template_kwargs gets removed
raw_prompt = self.processor.apply_chat_template(
messages, add_generation_prompt=True, tokenize=False, **self.apply_chat_template_kwargs
)