NRF2-963 Add datasets-plugin map example with excluded areas layer#301
Open
jonnywyatt wants to merge 7 commits into
Open
NRF2-963 Add datasets-plugin map example with excluded areas layer#301jonnywyatt wants to merge 7 commits into
jonnywyatt wants to merge 7 commits into
Conversation
Adds a standalone /quote/draw-boundary-datasets example page built on the interactive-map datasets plugin, demonstrating an EDP boundaries layer alongside a new excluded-areas layer proxied through a new excluded-areas-map route. Includes draw tools, boundary check/save, zoom-based fill opacity, and layer visibility toggling while drawing.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Addresses SonarCloud quality gate failures on PR #301: - Split the oversized wireDrawTools function into smaller functions - Use a Set (with .has()) instead of Array.includes() for DRAW_LAYERS - Add missing curly braces around an if statement - Prefer optional chaining in boundary-info.js area/perimeter formatting - Extract magic numbers (default zoom, Norfolk coordinates) into named constants - Add unit tests for all new client-side datasets modules to satisfy the 90% new-code coverage gate (datasets folder now at ~99% statement coverage)
…esize handling Removes service navigation and phase banner for full-screen map routes via a new fullScreen context flag, sets the header productName from serviceName, and keeps the map filling available height on viewport resize.
The productName toggle and service-navigation conditional were not needed after all — service navigation and header render the same regardless of fullScreen. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/quote/draw-boundary-datasetsexample page built on the interactive-map datasets plugin (rather than the existing custom layer-controls approach), demonstrating anedp_boundarieslayer alongside a newexcluded_areaslayer.excluded-areas-mapproxy route, since the excluded areas tile server doesn't return CORS headers permitting direct browser access./quote/draw-boundary/checkand/saveendpoints), zoom-based fill opacity reduction, and hiding vector layers while in draw mode._draw-boundary.scsscausing an unwanted vertical scrollbar on draw-boundary map pages (missingpadding-bottom: 0override on.govuk-main-wrapper).Test plan
npx eslint .andnpx stylelintpass🤖 Generated with Claude Code