feat: centralize fee logic and add Bitcoin deposit forwarding#3258
Draft
feat: centralize fee logic and add Bitcoin deposit forwarding#3258
Conversation
Move getSendFeeRate() into BitcoinBasedFeeService using template method pattern, eliminating duplicate fee multiplier logic across Bitcoin and Firo services. Add dedicated Bitcoin deposit forwarding with explicit UTXO selection and subtract_fee_from_outputs for accurate fee handling.
davidleomay
reviewed
Feb 26, 2026
Comment on lines
+195
to
+203
| // only use UTXOs from the payment address (not deposit UTXOs on the same wallet) | ||
| const utxos = await client.getUtxoForAddresses([paymentAddress], true); | ||
| if (!utxos.length) return ''; | ||
|
|
||
| const inputs = utxos.map((u) => ({ txid: u.txid, vout: u.vout })); | ||
| const utxoBalance = utxos.reduce((sum, u) => sum + u.amount, 0); | ||
|
|
||
| // sweep all UTXOs: send full balance and let Bitcoin Core subtract the fee from the output | ||
| return client.sendMany([{ addressTo: outputAddress, amount: utxoBalance }], feeRate, inputs, [0]); |
Member
There was a problem hiding this comment.
This logic is already in FiroClient.sendMany. Maybe we should add a method sendManyFromAddress to BitcoinBasedClient and reuse it in both places? Is this possible?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSendFeeRate()intoBitcoinBasedFeeServiceusing template method pattern, eliminating duplicate fee multiplier logic across Bitcoin and Firo servicessubtract_fee_from_outputsfor accurate fee handlinggetUtxoForAddresses()toNodeClientfor address-filtered UTXO queriesDexFiroService.getFeeRate()wrapper, unusedConfigimport inPayoutBitcoinServiceTest plan
npm run build)npm test)