Merged
Conversation
…3243) * feat: route REALU sell through BrokerBot via atomic EIP-7702 batch DFX must never receive REALU tokens. Instead of sending REALU directly to a DFX deposit address, the sell flow now routes through the BrokerBot: User -> REALU -> BrokerBot -> ZCHF -> DFX Deposit The atomic batch uses redeemDelegations with two calls: 1. transferAndCall (ERC-677): REALU to BrokerBot (triggers sell) 2. transfer (ERC-20): ZCHF to DFX deposit address Changes: - Add getBrokerbotSellPrice(), getBrokerbotAddress(), getZchfAddress() to RealUnitBlockchainService - Add executeBrokerBotSellForRealUnit() to Eip7702DelegationService with batch encoding for two calls in one atomic TX - Update confirmSell() in RealUnitService to use BrokerBot flow - Add unit tests (32 tests) for price calculation and batch encoding - Add Sepolia test contracts (TestREALU, TestZCHF, TestBrokerBot) and E2E test script verified on Sepolia (TX success) - Add platform: linux/amd64 to docker-compose.yml for Apple Silicon NOTE: realunit-blockchain.service.ts currently has Sepolia test contract addresses. Must revert to mainnet addresses before production merge. * feat: replace hardcoded contract addresses with dynamic resolution - Remove hardcoded BROKERBOT, REALU, ZCHF Sepolia addresses from realunit-blockchain.service - Resolve REALU and ZCHF addresses from asset DB via tokenBlockchain (Sepolia for DEV/LOC, Ethereum for PRD) - Resolve BrokerBot address from config, environment-aware - Add ZCHF Sepolia asset migration - Pass addresses as parameters to getBrokerbotInfo() * fix: prettier formatting * fix: remove unused imports in test-brokerbot-sell and migration * fix: move hardcoded keys to env vars in test scripts * fix: remove test-contracts from tracking (already in .gitignore) * fix: replace authorization: any with typed Eip7702Authorization interface * fix: redeploy BrokerBot with correct REALU/ZCHF Sepolia addresses * fix: deploy real Aktionariat Brokerbot on Sepolia with correct token addresses * fix: redeploy ZCHF + BrokerBot on Sepolia with correct token naming Replace tZCHF (Test Frankencoin) with properly named Frankencoin (ZCHF) contract and redeploy BrokerBot with new base currency address. * test: add unit tests for getBrokerbotInfo and confirmSell Add 4 tests to realunit-blockchain.service.spec.ts covering the new getBrokerbotInfo signature (address passthrough, price, buyingEnabled, sellingEnabled). Create realunit.service.spec.ts with 9 tests covering PR-changed methods: getBrokerbotInfo (asset resolution + delegation to blockchain service) and confirmSell (EIP-7702 flow, manual txHash, error cases). * fix: remove unused NotFoundException import in realunit.service.spec * fix: move test script to scripts/ and make migration idempotent - Move test-brokerbot-sell.js from repo root to scripts/ - Add IF NOT EXISTS guard to AddSepoliaZCHF migration to prevent duplicate insert failures on re-run * refactor: remove unused transferTokenWithUserDelegationForRealUnit Dead code — replaced by executeBrokerBotSellForRealUnit in the BrokerBot sell flow. No callers remain. * chore: remove unrelated docker-compose change and dev test script Remove platform: linux/amd64 from docker-compose.yml (unrelated to BrokerBot feature) and remove scripts/test-brokerbot-sell.js (manual E2E dev tool, not production code). * feat: use correct brokerbot for sellPrice for testnet and mainnet. * chore: handling sell price when zero. * test: fix realunit service test. --------- Co-authored-by: TuanLamNguyen <xnguyen.lam@gmail.com>
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* feat: added Scrypt deposit requests * fix: format
davidleomay
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist