fix: resolve circular dependency in NameCheckService#3279
Merged
TaprootFreak merged 2 commits intodevelopfrom Feb 26, 2026
Merged
fix: resolve circular dependency in NameCheckService#3279TaprootFreak merged 2 commits intodevelopfrom
TaprootFreak merged 2 commits intodevelopfrom
Conversation
Add forwardRef() for UserDataService injection in NameCheckService to break the circular dependency chain introduced by #3275: KycService → NameCheckService → UserDataService → KycService Without forwardRef, NestJS cannot resolve this indirect circular dependency on server startup, causing the DEV API to crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forwardRef()forUserDataServiceinjection inNameCheckServiceto break the indirect circular dependency chain introduced by feat: add sanctions guard for KYC Level 30 and 50 #3275KycService→NameCheckService→UserDataService→KycService— withoutforwardRef, NestJS cannot resolve this on server startup, causing the DEV API to crashTest plan
yarn lint && yarn build && yarn testall green