fix: wrap native coin balance call in try-catch#3280
Merged
TaprootFreak merged 1 commit intodevelopfrom Feb 26, 2026
Merged
Conversation
getNativeCoinBalanceForAddress was not protected by error handling, unlike getTokenBalances. When a blockchain node becomes unresponsive (e.g. Firo RPC timeout), the unhandled error propagates through Promise.all and crashes the entire saveTradingLog cron job, stopping all FinancialDataLog and FinancialChangesLog entries.
davidleomay
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNativeCoinBalanceForAddress()inPaymentBalanceService.getPaymentBalances()was not wrapped in a try-catch, unlikegetTokenBalances()directly below it10.0.1.5:8888timing out after ~137s), the unhandled error propagates throughPromise.alland crashessaveTradingLog()getNativeCoinBalanceForAddressandgetTokenBalancesinto one shared try-catch that respects the existingcatchExceptionflagRoot cause
The Firo RPC node is unresponsive, causing
Util.timeout()to throwError: Timeoutafter ~137-180 seconds. This error was not caught for native coin balance queries.Test plan
10.0.1.5:8888