Remove value-based coloring from tracks in spatial_overview #565
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spatial_overview plot previously colored track observations by their values using a "Reds" colormap. This was confusing because: - There was no colorbar or legend explaining what the colors meant - The purpose of spatial_overview is to show WHERE observations are, not WHAT values they contain Track observations now use a uniform color (matplotlib's default cycle), consistent with how point observations are displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
spatial_overviewnow use a uniform color instead of being colored by their valuesspatial_overviewis to show where observations are located, not what values they containThis change will make it easier to remove/refactor the confusing
Comparer._to_observation()(Looking at the plot, it would be nice to have an option to exclude data outside the model domain, but we'll ignore that for now)
Before
After