Skip to content

Fix typos CI#109

Merged
JoshuaLampert merged 8 commits intomainfrom
fix-typo-ci
Mar 2, 2026
Merged

Fix typos CI#109
JoshuaLampert merged 8 commits intomainfrom
fix-typo-ci

Conversation

@JoshuaLampert
Copy link
Collaborator

The typos CI check in #108 failed after the update. This should fix it again by making an exception for "iz", which is used as a variable name.

@JoshuaLampert JoshuaLampert requested a review from benegee March 2, 2026 08:58
Copy link
Collaborator

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JoshuaLampert for taking care!

@benegee
Copy link
Collaborator

benegee commented Mar 2, 2026

Hm... Downgrade failing, which had not been triggered in #108 . Do you understand what exactly is "Unsatisfiable" here?

@JoshuaLampert
Copy link
Collaborator Author

I have seen that in P4est.jl, too. I'll investigate.

@JoshuaLampert
Copy link
Collaborator Author

Ok, I have an idea why downgrade failed. It's related to v2.2.1 of the downgrade compat action, where I changed the default julia version Resolver.jl uses. Previously, the default was v1.10 and I changed it to version of the current runtime, which fixed some issues. However, this means Resolver.jl now ran with julia v1.9, which apparently led to some problem with Resolver.jl I do not fully understand. I suggest to just run Downgrade on julia v1.10 since it is the LTS anyway.
I also changed to the forcedeps mode since is the one I prefer because it verifies we have the correct compat bounds set. However, there is another smaller issue with the downgrade compat action because for the JLL packages there are the build numbers +x in the package versions, which are not correctly recognized by the action, which means it fails. I'll see if I can fix that there.

@ranocha
Copy link
Collaborator

ranocha commented Mar 2, 2026

@benegee Please do not merge spell checker updates if the corresponding CI job fails.

@JoshuaLampert
Copy link
Collaborator Author

Should be fixed by julia-actions/julia-downgrade-compat#42.

@JoshuaLampert
Copy link
Collaborator Author

Ok, the Downgrade action is fixed and a new version released. Tests pass again.

@JoshuaLampert JoshuaLampert merged commit c61d869 into main Mar 2, 2026
15 of 16 checks passed
@JoshuaLampert JoshuaLampert deleted the fix-typo-ci branch March 2, 2026 14:07
@ranocha
Copy link
Collaborator

ranocha commented Mar 2, 2026

Thanks a lot, Joshua!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants