Restructure project into feature/domain/shared areas, add path aliases and UI shell components#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Appcomposition.Description
src/features/*,src/domain/*, andsrc/shared/*, and added feature index entrypoints (for example@features/display,@features/instrument,@features/export,@features/practice,@features/theory,@features/fretboard,@features/share).tsconfig.jsonandvite.config.js(@app/*,@features/*,@shared/*,@domain/*,@styles/*, and kept@/*as fallback).Appinto new modules:AppPanels,AppModals(insrc/app/shell/AppPanels.jsx),StageShell(insrc/app/shell/StageShell.jsx), andToastProvider(insrc/app/providers/ToastProvider.jsx), and updatedApp.jsxto use them.src/shared/lib/*andsrc/shared/ui/*, moved pure domain music-theory modules intosrc/domain/*, and updated many store/hooks/components to use the new locations.docs/project-structure.mddocumenting the new organization and import boundary rules.knip.jsonentry glob extended to include.{js,jsx,ts,tsx}tests, and many tests/files were relocated to mirror the new structure undersrc/tests/**.Testing
npm testwhich exercised the renamed modules and tests paths; the test suite completed successfully.tsc --noEmitagainst the updatedtsconfig.jsonto validate path aliases and types; the typecheck completed successfully.npm run dev) and confirming the app bootstraps without missing-module errors.Codex Task