Skip to content

fix: use remove_cvref_t in void or_else construct_empty#17

Merged
DNKpp merged 1 commit into
DNKpp:mainfrom
marquisburg:main
May 30, 2026
Merged

fix: use remove_cvref_t in void or_else construct_empty#17
DNKpp merged 1 commit into
DNKpp:mainfrom
marquisburg:main

Conversation

@marquisburg

Copy link
Copy Markdown
Contributor

Void or_else failed to compile when the nullable was passed as an lvalue, because construct_empty was instantiated with a reference type.

Void or_else failed to compile when the nullable was passed as an lvalue,
because construct_empty was instantiated with a reference type.
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 26534309345

Coverage remained the same at 92.929%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 157
Covered Lines: 152
Line Coverage: 96.82%
Relevant Branches: 41
Covered Branches: 32
Branch Coverage: 78.05%
Branches in Coverage %: Yes
Coverage Strength: 36.36 hits per line

💛 - Coveralls

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (66f0f89) to head (3b0a4b4).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files          11       11           
  Lines         152      152           
  Branches       23       23           
=======================================
  Hits          147      147           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DNKpp DNKpp merged commit 80f34a4 into DNKpp:main May 30, 2026
172 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants