Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Imports:
lifecycle,
httr2,
desc
RoxygenNote: 7.3.2
RoxygenNote: 7.3.3
Suggests:
knitr,
rmarkdown,
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# QCkit v1.2.1
## 2026-02-26
* update `get_elevation` to handle unpredictable API responses for invalid lat/long values.
* update unit tests to pass using DataStore v8 API
* update unit tests for `summarize_qc_flags` to reflect changes made in the function

## 2025-01-09
* `create_datastore_script` now has a new parameter, lib_type. If "R" is specified it will pull as much info as it can from the DESCRIPTION file of an R package and use that info to fill out the Core Bibliography tab on the reference landing page.

Expand Down
6 changes: 5 additions & 1 deletion R/datastore_interactions.R
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,11 @@ create_datastore_script <- function(owner,
if (force == FALSE) {
cat("Your file, ", crayon::blue$bold(file_name),
", has been uploaded to:\n", sep = "")
cat(ds_resource_url, "\n\n", sep = "")


#### ds_resource_url is not a good url; needs fixing

cat(ds_resource_url, "\n\n", sep = "")
}
#add a web link:
#release url:
Expand Down
5 changes: 3 additions & 2 deletions R/elevation.R
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,15 @@ get_elevation <- function(df,
if (req$status_code == 200) {
gh_req_json <- suppressMessages(httr::content(req, "text"))
# if something else went wrong - likely coordinates outside USA.
if (gh_req_json == "Invalid or missing input parameters."){
if (gh_req_json == "Invalid or missing input parameters." |
grepl("Call failed", gh_req_json)){
if (force == FALSE){
cat("Invalid input. NAs generated. Are your coordinates inside the US?")
}
elev <- append(elev, NA)
} else {
# everything checks out, add elevation to df
elevation <- httr::content(req)$value
elevation <- as.numeric(httr::content(req)$value)
elev <- append(elev, elevation)
}
} else {
Expand Down
83 changes: 0 additions & 83 deletions docs/404.html

This file was deleted.

2 changes: 1 addition & 1 deletion docs/CONTRIBUTING.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/LICENSE-text.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/LICENSE.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading