Fix lro.db

[chkim-usgs]

Addresses DOI-USGS/ISIS3#5863

The LROC polar data was moved from lroc to moc in lro.json db. Will also need to address the makedb in the EFS lro/kernels/ck similarly.

Previous related PR: #122

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

• I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

[Kelvinrr]

needs a changelog

[lwellerastro]

Hey @chkim-usgs, @Kelvinrr, I just happened to be looking at the isisKernelList.txt for LRO and noticed that the NPole kernel set includes redundant kernels we should probably remove.

I'm also seeing the extraneous kernels under the isis9.0.0 data area:

ls -1 /usgs/cpkgs/isis3/isis_data/lro/kernels/*/*NPOLE_2017Merged*
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Left_2009_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Left_2010_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Left_2011_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Left_2012_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Left_2013_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Left_2014_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Left_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Right_2009_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Right_2010_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Right_2011_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Right_2012_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Right_2013_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Right_2014_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/ck/LROC_NPOLE_2017Merged_Lidar2Image_Right_ck.bc
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Left_2009_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Left_2010_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Left_2011_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Left_2012_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Left_2013_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Left_2014_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Left_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Right_2009_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Right_2010_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Right_2011_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Right_2012_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Right_2013_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Right_2014_spk.bsp
/usgs/cpkgs/isis3/isis_data/lro/kernels/spk/LROC_NPOLE_2017Merged_Lidar2Image_Right_spk.bsp

The extraneous kernels are
LROC_NPOLE_2017Merged_Lidar2Image_Left_ck.bc
LROC_NPOLE_2017Merged_Lidar2Image_Right_ck.bc
LROC_NPOLE_2017Merged_Lidar2Image_Left_spk.bsp
LROC_NPOLE_2017Merged_Lidar2Image_Right_spk.bsp

We were able to make single kernels for the north pole data using the writer programs which is what these 4 named kernels represent, but because we could not do the same for the south pole we decided to break things out by years for both poles.

I don't see that these all image NPole kernels were released via the scibase site, only the by year kernels so I'm not sure how these were included in the first place. We probably should be mimicking our release for consistency. If both an all image and by Year kernel is loaded it may be confusing (and I'm not sure what the actual result will be like).

I'm wondering what happens for say a north pole left eye image from 2014? Will spiceinit load the Left_2014 ck and spk kernels as well as LROC_NPOLE_2017Merged_Lidar2Image_Left_ck.bc and LROC_NPOLE_2017Merged_Lidar2Image_Left_spk.bsp? And in what order? What will show up on the image label?

Sorry I didn't catch this sooner, but I'm only seeing today that the original post was updated a couple of weeks ago (while I was on leave).

[chkim-usgs]

@lwellerastro, thanks for the catch. Created a PR that removes the four extraneous kernels from the test kernel list and also removed the four kernels from the ISIS data area on EFS.