[2.0.0] Remove isis_formatter and usgscsm_formatter#698
Open
jrcain-usgs wants to merge 18 commits intoDOI-USGS:mainfrom
Open
[2.0.0] Remove isis_formatter and usgscsm_formatter#698jrcain-usgs wants to merge 18 commits intoDOI-USGS:mainfrom
jrcain-usgs wants to merge 18 commits intoDOI-USGS:mainfrom
Conversation
acpaquette
reviewed
Apr 17, 2026
Comment on lines
+81
to
+84
| formatter : {'ale'} ('isis', and 'usgscsm' are deprecated) | ||
| Output format for the ISD. As of 1.2.0, the | ||
| `ale` formatter is always used. The parameter is retained | ||
| for backwards compatibility. |
Collaborator
There was a problem hiding this comment.
Everything looks good but a breaking change like this would require a version tick to ALE 2.0.0. In ISIS we usually hold any breaking change for the yearly release, I don't know what we should do for ALE. With the spiceql changes and the gdal additions we could likely do a 2.0.0. @Kelvinrr thoughts?
Collaborator
There was a problem hiding this comment.
we should probably hold off on this for this reason. At least we should see if there are more API breaking changes we can pile on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #653
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: