Skip to content

[2.0.0] Remove isis_formatter and usgscsm_formatter#698

Open
jrcain-usgs wants to merge 18 commits intoDOI-USGS:mainfrom
jrcain-usgs:clean-formatter
Open

[2.0.0] Remove isis_formatter and usgscsm_formatter#698
jrcain-usgs wants to merge 18 commits intoDOI-USGS:mainfrom
jrcain-usgs:clean-formatter

Conversation

@jrcain-usgs
Copy link
Copy Markdown
Contributor

Fixes #653

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@jrcain-usgs jrcain-usgs marked this pull request as ready for review April 15, 2026 23:05
@jrcain-usgs jrcain-usgs changed the title Clean formatter Remove isis_formatter and usgscsm_formatter Apr 15, 2026
Comment thread ale/drivers/__init__.py
Comment on lines +81 to +84
formatter : {'ale'} ('isis', and 'usgscsm' are deprecated)
Output format for the ISD. As of 1.2.0, the
`ale` formatter is always used. The parameter is retained
for backwards compatibility.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but a breaking change like this would require a version tick to ALE 2.0.0. In ISIS we usually hold any breaking change for the yearly release, I don't know what we should do for ALE. With the spiceql changes and the gdal additions we could likely do a 2.0.0. @Kelvinrr thoughts?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably hold off on this for this reason. At least we should see if there are more API breaking changes we can pile on.

@jrcain-usgs jrcain-usgs changed the title Remove isis_formatter and usgscsm_formatter [2.0.0] Remove isis_formatter and usgscsm_formatter Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old unused formatter logic

3 participants