Skip to content

Refactor control module improvements#47

Merged
pnorton-usgs merged 10 commits intodevelopmentfrom
refactor/control-improvements
May 8, 2026
Merged

Refactor control module improvements#47
pnorton-usgs merged 10 commits intodevelopmentfrom
refactor/control-improvements

Conversation

@pnorton-usgs
Copy link
Copy Markdown
Member

Minor refactoring and bug fixes across the control module files.

Changes

  • Control.py: Use context manager (with open) in write() for safe file handling
  • Control.py: Replace assert False with raise NotImplementedError in _read()
  • ControlFile.py: Fix filename property return type to Path (setter already converts)
  • ControlVariable.py: Simplify _value_meaning_test - remove nested try/except and regex in favor of direct lookups; remove unused re import

Testing

All 54 control module tests pass.

@pnorton-usgs pnorton-usgs self-assigned this May 8, 2026
@pnorton-usgs pnorton-usgs merged commit 1d604ec into development May 8, 2026
7 checks passed
@pnorton-usgs pnorton-usgs deleted the refactor/control-improvements branch May 8, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant