Modernize type hints in dimension modules#48
Merged
pnorton-usgs merged 2 commits intodevelopmentfrom May 8, 2026
Merged
Conversation
- Replace typing.Dict, Optional, Union with built-in generics and X|Y syntax - Add 'from __future__ import annotations' for runtime compatibility - Remove unused class-level annotations in Dimension - Simplify super() calls to Python 3 style - Remove dead commented-out code
- test_dimension.py -> test_Dimension.py - test_dimensions.py -> test_Dimensions.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize type hints in dimension modules
Summary
Modernize type annotations in
Dimension.pyandDimensions.pyto use Python 3.10+ syntax, and fix test file naming to follow project conventions.Changes
typing.Dict,Optional,Unionwith built-in generics andX | Yunion syntaxfrom __future__ import annotationsfor runtime compatibilityDimensionsuper()calls to Python 3 styletest_dimension.py→test_Dimension.pyandtest_dimensions.py→test_Dimensions.pyto match thetest_<ClassName>.pyconventionTesting
All 290 tests pass. No new mypy errors introduced in the modified files.