Fix for shapefiles in the cloud?#340
Closed
ldecicco-USGS wants to merge 1 commit intoDOI-USGS:mainfrom
Closed
Conversation
Collaborator
|
Thanks Laura -- I'm on leave till January 5th and will look into what's up here when I'm back. |
Collaborator
|
I used more or less this pattern in a commit I have incoming. Thanks for the head start @ldecicco-USGS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cuid and key are needed for downloads, and seem to get lost in
get_facet_files.I'm not confident on how/if this would break other things. I got 2 failed tests, but they might be unrelated (a 404 on an item).
This is what was failing (and now works):