Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1
Issues include
Alt Text
Alternate Text is required for images. I updated the README to describe how to include alt text and when not doing so is appropriate.
Color Contrast
Color contrast violations appear with the originally selected theme, which I updated to
cosmos. It also appears thatthemeand many other frontmatter options were set multiple times on the page-level, so I removed these in order to let the project-level frontmatter apply. Additionally, color contrast errors appear if code-style is used within a quote (changes made to the Project A1 page).Aria Allowed Attributes
This violation has to do with
callout's. I added a script that will injectrole="button"` to fix this.Scrollable Region Focusable
This violation appears for scrollable regions like wide blocks of code. I added a script that injects
tabindex=0so they are able to be accessed by keyboard users.Remove PDF
https://ds100.org/debugging-guide/Data-100-Debugging-Guide.pdf