fix(compiler): move register tracking side-effect out of ZEN_ASSERT in copyParam#474
Open
ys8888john wants to merge 2 commits into
Open
fix(compiler): move register tracking side-effect out of ZEN_ASSERT in copyParam#474ys8888john wants to merge 2 commits into
ys8888john wants to merge 2 commits into
Conversation
ys8888john
changed the title
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions |
zoowii
reviewed
Apr 16, 2026
| Opnd); | ||
| if (Kind == WASMTypeKind::INTEGER) { | ||
| ZEN_ASSERT(GpRegUsed |= (1 << Reg)); | ||
| GpRegUsed |= (1 << Reg); |
Contributor
There was a problem hiding this comment.
add change doc and test cases for this
Contributor
Author
There was a problem hiding this comment.
Change doc added. The original ZEN_ASSERT(GpRegUsed |= (1 << Reg)) was always true so bitwise OR with (1 << Reg) always yields a non-zero result so the assert had no real checking value. The fix simply moves the side-effect out of the assert. Since GpRegUsed is only consumed by another assert (the conflict check above), there's no observable difference in generated code between the buggy and fixed versions, so no test case can meaningfully validate this change.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates single-pass compiler call-argument handling to avoid relying on ZEN_ASSERT for a side-effect when tracking used registers during copyParam.
Changes:
- Move register-used bitmask updates (
GpRegUsed/FpRegUsed) out ofZEN_ASSERTand into normal statements. - Preserve existing argument move logic while ensuring register tracking always executes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ys8888john
force-pushed
the
fix-p2-h09-bug
branch
2 times, most recently
from
071817d to
1e49fea
Compare
Contributor
|
@ys8888john conflict |
…n copyParam Co-authored-by: Aone Copilot <copilot@aone.alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n copyParam
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note