Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(evm): add profile-guided JIT with thread pool and sliding window profiling #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(evm): add profile-guided JIT with thread pool and sliding window profiling #481
Changes from all commits
0b89021039188038ea784d05e398415cc1bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NumJITCompileThreads can be set to 0 programmatically, but JITCompilePool(0) will accept tasks that never run, and shutdown/destruction can then block forever waiting for unfinished futures. Add validation (e.g., in RuntimeConfig::validate) to ensure NumJITCompileThreads >= 1 (and ideally cap it consistently with set_option’s limit) when profile-guided JIT is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When EnableProfileGuidedJIT is true, module creation skips the EVMAnalyzer and never sets ShouldFallbackToInterp. That means contracts that should permanently fall back to interpreter mode can still get JIT-triggered later, and the execute() hot path comment about the flag being set at creation becomes false. Consider running the analyzer even in profile-guided mode to set ShouldFallbackToInterp (without compiling), or otherwise persist the rejection decision onto the module so execute() can reliably avoid JIT for unsupported contracts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test binary previously exposed --enable-multipass-lazy like the other CLIs/tests, but that option is removed here. If existing CI scripts or local workflows pass --enable-multipass-lazy to this binary, they'll now fail argument parsing. Consider keeping the flag for parity/backward-compatibility (even if unused for solidity tests) alongside the new --enable-profile-guided-jit option.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.