ci: add sccache ninja canary#509
Closed
abmcar wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a default-off CI build helper to experiment with Ninja and sccache in one EVM x86 ctest canary job while keeping the broader CI path unchanged by default.
Changes:
- Adds
.ci/cmake_ci_build.shto centralize CMake configure/build invocation with optional Ninja and sccache. - Routes
.ci/run_test_suite.sh’s main configure/build loop through the helper and adds dry-run support. - Enables Ninja+sccache and prints sccache stats for the selected EVM canary workflow job.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/dtvm_evm_test_x86.yml |
Enables and reports Ninja/sccache behavior for one EVM x86 canary job. |
.ci/run_test_suite.sh |
Delegates the main build loop to the new helper and adds dry-run skips. |
.ci/cmake_ci_build.sh |
New CMake configure/build wrapper with optional Ninja, sccache, and job-count toggles. |
Comments suppressed due to low confidence (1)
.github/workflows/dtvm_evm_test_x86.yml:84
- This logs
SCCACHE_BASEDIRS, which is not a recognized sccache setting; after correcting the configuration toSCCACHE_BASEDIR, this line should log the singular variable so the canary output reflects the setting sccache actually uses.
echo "SCCACHE_BASEDIRS=$SCCACHE_BASEDIRS"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Closing this upstream PR because it is a test/canary PR. Continuing validation in the fork PR instead: abmcar#16 |
Contributor
Author
|
Closed in favor of fork-only test PR: abmcar#16 |
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a canary path for CI build acceleration using Ninja plus sccache in one representative EVM job.
Scope is intentionally narrow:
.ci/cmake_ci_build.shwith default-offDTVM_CI_USE_NINJAandDTVM_CI_USE_SCCACHEtoggles.ci/run_test_suite.shconfigure/build loop through the helperbuild_test_release_multipass_lazy_evmtestsuite_on_x86_ctestcompile_requests > 0Validation
Local validation run:
bash -n .ci/cmake_ci_build.sh .ci/run_test_suite.shgit diff --cached --checkrun_test_suite.shpathcmake --build build-helper-smoke -j $(nproc)Known local limits:
sccacheis not installed, so GHA backend behavior must be verified by PR CIactionlintis not installedtools/format.sh checkcurrently fails on existing unrelated C/C++ clang-format violations outside this changeCI measurement target
This PR is for canary data collection first. Please compare cold-cache and warm-cache runs for:
Build and Teststep durationsccache compile_requestssccache aggregate_cache_hitsfromstats.cache_hits.countsIf warm-cache data is useful and stable, later PRs can roll the same helper out to the remaining EVM/WASM jobs.