Skip to content

Don't add tp_src_ids for ro apps with tp_generation disabled#281

Closed
gcrone wants to merge 1 commit intopatch/fddaq-v5.6.xfrom
gcrone/tp_src_fix
Closed

Don't add tp_src_ids for ro apps with tp_generation disabled#281
gcrone wants to merge 1 commit intopatch/fddaq-v5.6.xfrom
gcrone/tp_src_fix

Conversation

@gcrone
Copy link
Copy Markdown
Contributor

@gcrone gcrone commented Mar 20, 2026

Description

Disabling tp generation in ReadoutApplication results in requests for tps to an unknown sender. This is because the MLT was getting a list of tp source ids for the ReadoutApplication. This patch adds a check to the ConfigurationHelper::get_tp_source_ids method to set an empty vector for ReadoutApplications with tp_generation_enabled set to false.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@gcrone gcrone requested a review from mroda88 March 20, 2026 13:52
@gcrone gcrone closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants