Don't add tp_src_ids for ro apps with tp_generation disabled#281
Closed
gcrone wants to merge 1 commit intopatch/fddaq-v5.6.xfrom
Closed
Don't add tp_src_ids for ro apps with tp_generation disabled#281gcrone wants to merge 1 commit intopatch/fddaq-v5.6.xfrom
gcrone wants to merge 1 commit intopatch/fddaq-v5.6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disabling tp generation in ReadoutApplication results in requests for tps to an unknown sender. This is because the MLT was getting a list of tp source ids for the ReadoutApplication. This patch adds a check to the
ConfigurationHelper::get_tp_source_idsmethod to set an empty vector for ReadoutApplications with tp_generation_enabled set to false.Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))