Skip to content

Prep release/fddaq v5.6.0#282

Merged
mroda88 merged 2 commits intodevelopfrom
prep-release/fddaq-v5.6.0
Mar 20, 2026
Merged

Prep release/fddaq v5.6.0#282
mroda88 merged 2 commits intodevelopfrom
prep-release/fddaq-v5.6.0

Conversation

@mroda88
Copy link
Copy Markdown
Contributor

@mroda88 mroda88 commented Mar 20, 2026

Description

This fixes a but in the configuration helper that exposed the TP source IDs even when the TP generation was disabled.

To test, just run a configuration without TPG and with TP source IDs associated to the readout application. The requests will be correct. Without this fix, the system will not be able to complete TRs.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@mroda88 mroda88 requested a review from gcrone March 20, 2026 14:59
@mroda88 mroda88 self-assigned this Mar 20, 2026
@mroda88 mroda88 added the bug Something isn't working label Mar 20, 2026
@mroda88 mroda88 merged commit 3780fa2 into develop Mar 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants