Skip to content

NUMA allocation with NP02ReadoutApplication and fake readers #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShyamB97 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

NUMA allocation with NP02ReadoutApplication and fake readers #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7699c32
allow using NUMA allocaito through the dpdk receivers when FDFakeRead…
ShyamB97 Mar 25, 2026
ceca04f
remove TLOGs from debugging
ShyamB97 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/NP02ReadoutApplication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,18 +208,21 @@ NP02ReadoutApplication::generate_modules(std::shared_ptr<appmodel::Configuration
auto det_senders = d2d_conn->senders();
auto det_receiver = d2d_conn->receiver();


// Here I want to resolve the type of connection (network, felix, or?)
// Rules of engagement: if the receiver interface is network or felix, the receivers should be castable to the counterpart
if (reader_class == "DPDKReaderModule" || reader_class == "SocketReaderModule") {
if (reader_class == "DPDKReaderModule" || reader_class == "SocketReaderModule" || reader_class == "FDFakeReaderModule") {
if ((reader_class == "DPDKReaderModule" && !det_receiver->cast<appmodel::DPDKReceiver>()) ||
(reader_class == "FDFakeReaderModule" && !det_receiver->cast<appmodel::DPDKReceiver>()) || // SSB: Note here, we are intrinsically locking FakeCard readout to only emulate DPDK data reception. Given NP02ReadoutApplication is intended for TDE readout at NP02, assuming this is OK.
(reader_class == "SocketReaderModule" && !det_receiver->cast<appmodel::SocketReceiver>())) {
throw(BadConf(ERS_HERE, fmt::format("{} requires NWDetDataReceiver, found {} of class {}", reader_class, det_receiver->UID(), det_receiver->class_name())));
}

if (reader_class == "DPDKReaderModule") {
// SSB: Note that here you need to include FDFakeCardReader as well, because emulated readout needs some way to map NUMA to streams
// Since we require a receiver in the NetworkDetector2DAQConnections this would still work if the receiver type is a DPDKReceiver
if (reader_class == "DPDKReaderModule" || reader_class == "FDFakeReaderModule") {
auto dpdk_reciever = det_receiver->cast<appmodel::DPDKReceiver>();
receiver_numa = (int16_t)dpdk_reciever->get_uses()->get_numa_id();
TLOG() << "receiver numa: " << receiver_numa;
}

bool all_nw_senders = true;
Expand Down