Combined the find_free_k8s_nodeport and find_free_port functions…#607
Merged
MRiganSUSX merged 1 commit intomrigan/k8s_changesfrom Nov 4, 2025
Merged
Conversation
… a single one that supports an optional range; promoted a few warnings to errors in set_connectivity_service_port.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… into a single one that supports an optional range; promoted a few warnings to errors in set_connectivity_service_port.py
Description
This Pull Request builds on the changes in #603, and the target merge branch is
mrigan/k8s_changes.My sense is that providing a single
find_free_portfunction is cleaner than providing separate ones for K8s and non-K8s uses.And, it seemed that several of the warnings in the
set_connectivity_service_portPython function should actually be errors since several of the conditions seemed quite likely to cause problems later (with inconsistent information in the configuration).I tested these changes with the usual regression tests.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))