Skip to content

Combined the find_free_k8s_nodeport and find_free_port functions…#607

Merged
MRiganSUSX merged 1 commit intomrigan/k8s_changesfrom
kbiery/tweaks_to_k8s_changes
Nov 4, 2025
Merged

Combined the find_free_k8s_nodeport and find_free_port functions…#607
MRiganSUSX merged 1 commit intomrigan/k8s_changesfrom
kbiery/tweaks_to_k8s_changes

Conversation

@bieryAtFnal
Copy link
Copy Markdown
Contributor

… into a single one that supports an optional range; promoted a few warnings to errors in set_connectivity_service_port.py

Description

This Pull Request builds on the changes in #603, and the target merge branch is mrigan/k8s_changes.

My sense is that providing a single find_free_port function is cleaner than providing separate ones for K8s and non-K8s uses.

And, it seemed that several of the warnings in the set_connectivity_service_port Python function should actually be errors since several of the conditions seemed quite likely to cause problems later (with inconsistent information in the configuration).

I tested these changes with the usual regression tests.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

… a single one that supports an optional range; promoted a few warnings to errors in set_connectivity_service_port.py
Copy link
Copy Markdown
Contributor

@MRiganSUSX MRiganSUSX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MRiganSUSX MRiganSUSX merged commit 49392c5 into mrigan/k8s_changes Nov 4, 2025
1 check passed
@MRiganSUSX MRiganSUSX deleted the kbiery/tweaks_to_k8s_changes branch November 4, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants