CRT readers communicate with socket writers via IOM#622
Closed
denizergonul wants to merge 6 commits intodevelopfrom
Closed
CRT readers communicate with socket writers via IOM#622denizergonul wants to merge 6 commits intodevelopfrom
denizergonul wants to merge 6 commits intodevelopfrom
Conversation
This was referenced Mar 11, 2026
eflumerf
approved these changes
Mar 12, 2026
eflumerf
approved these changes
Mar 13, 2026
mode. Needed for readout_type_scan_test.py to correctly generate.
wesketchum
requested changes
Mar 23, 2026
Contributor
wesketchum
left a comment
There was a problem hiding this comment.
I'll continue the conversation on this PR, though see #624 for the PR we should merge to the prep-release branch.
I think there's an issue with this line:
daqconf/python/daqconf/generate.py
Line 736 in f1e0c4c
When I try to run the readout_type_scan.py integration test, I get errors like:
==================================== ERRORS ====================================
_ ERROR at setup of test_dunerc_success[BernCRT_System-StandAloneSSH_PM-run_dunerc0] _
../.venv/lib/python3.12/site-packages/integrationtest/integrationtest_drunc.py:220: in create_config_files
generate_readout(
../install/daqconf/lib64/python/daqconf/generate.py:736: in generate_readout
callback_desc=cb_desc,
^^^^^^^
E UnboundLocalError: cannot access local variable 'cb_desc' where it is not associated with a value
_ ERROR at setup of test_log_files[BernCRT_System-StandAloneSSH_PM-run_dunerc0] _
../.venv/lib/python3.12/site-packages/integrationtest/integrationtest_drunc.py:220: in create_config_files
generate_readout(
../install/daqconf/lib64/python/daqconf/generate.py:736: in generate_readout
callback_desc=cb_desc,
^^^^^^^
E UnboundLocalError: cannot access local variable 'cb_desc' where it is not associated with a value
_ ERROR at setup of test_data_files[BernCRT_System-StandAloneSSH_PM-run_dunerc0] _
../.venv/lib/python3.12/site-packages/integrationtest/integrationtest_drunc.py:220: in create_config_files
generate_readout(
../install/daqconf/lib64/python/daqconf/generate.py:736: in generate_readout
callback_desc=cb_desc,
^^^^^^^
E UnboundLocalError: cannot access local variable 'cb_desc' where it is not associated with a value
_ ERROR at setup of test_dunerc_success[GrenobleCRT_System-StandAloneSSH_PM-run_dunerc0] _
../.venv/lib/python3.12/site-packages/integrationtest/integrationtest_drunc.py:220: in create_config_files
generate_readout(
../install/daqconf/lib64/python/daqconf/generate.py:736: in generate_readout
callback_desc=cb_desc,
^^^^^^^
E UnboundLocalError: cannot access local variable 'cb_desc' where it is not associated with a value
_ ERROR at setup of test_log_files[GrenobleCRT_System-StandAloneSSH_PM-run_dunerc0] _
../.venv/lib/python3.12/site-packages/integrationtest/integrationtest_drunc.py:220: in create_config_files
generate_readout(
../install/daqconf/lib64/python/daqconf/generate.py:736: in generate_readout
callback_desc=cb_desc,
^^^^^^^
E UnboundLocalError: cannot access local variable 'cb_desc' where it is not associated with a value
_ ERROR at setup of test_data_files[GrenobleCRT_System-StandAloneSSH_PM-run_dunerc0] _
../.venv/lib/python3.12/site-packages/integrationtest/integrationtest_drunc.py:220: in create_config_files
generate_readout(
../install/daqconf/lib64/python/daqconf/generate.py:736: in generate_readout
callback_desc=cb_desc,
^^^^^^^
E UnboundLocalError: cannot access local variable 'cb_desc' where it is not associated with a value
I haven't fully tracked this down, but I think with the recent changes there is no callback descriptor that is being used for the CRT Bern and CRT Grenoble cases, where it is still instantiating a readout application in the readout type scan.
Attach DataMoveCallbackConf objects to the ReadoutApplication for CRT mode
Contributor
|
Closing this PR since the branch has been merged to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To try out:
create_config_plot -f config/daqsystemtest/example-configs.data.xml -r crt-data-source-01 -s local-socket-1x1-configcreate_config_plot -f config/daqsystemtest/example-configs.data.xml -r socket-ru-01 -s local-socket-1x1-configappmodel PR dte/crt_topology_change
daqsystemtest PR dte/crt_topology_change
crtmodules PR dte/crt_topology_change
asiolibs PR dte/crt_topology_change
daqconf PR dte/crt_cb_update
datahandlinglibs PR dte/cb_acquire
fdreadoutmodules PR dte/crt_rates