Skip to content

Add pytest to daqpytools#61

Open
emmuhamm wants to merge 6 commits intodevelopfrom
emmuhamm/add-just-pytest
Open

Add pytest to daqpytools#61
emmuhamm wants to merge 6 commits intodevelopfrom
emmuhamm/add-just-pytest

Conversation

@emmuhamm
Copy link
Copy Markdown
Collaborator

@emmuhamm emmuhamm commented Mar 19, 2026

Description

Fix #39

Add tests.

NGL pretty much all of this is copilot generated. However I did ask it to make most of the relevant ones and I did go through it to see if it makes sense. I've checked it and to my knowledge its doing what it needs to do.

Type of change

  • New feature or enhancement (non-breaking change which adds functionality)

Testing checklist

Run pytest and see if it works

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@emmuhamm emmuhamm changed the base branch from emmuhamm/deploy-docs to develop March 19, 2026 11:33
@emmuhamm emmuhamm changed the title Emmuhamm/add just pytest Add pytest Mar 19, 2026
@emmuhamm emmuhamm self-assigned this Mar 19, 2026
@emmuhamm emmuhamm force-pushed the emmuhamm/add-just-pytest branch from 5b3a0a3 to f4e7325 Compare March 20, 2026 16:09
@emmuhamm emmuhamm requested a review from PawelPlesniak March 20, 2026 16:34
@emmuhamm emmuhamm marked this pull request as ready for review March 20, 2026 16:35
@emmuhamm emmuhamm added the enhancement New feature or request label Mar 20, 2026
@emmuhamm emmuhamm changed the title Add pytest Add pytest to daqpytools Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Unit tests for logging/ers

2 participants