Add safe env injector in logging demonstrator#65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #58
See above for full desc.
Add a new class called
EnvInjectorwhich does this automatically for us:Used in any of the tests that require this environment variable.
Atm only defined in logging demonstrator, as it is unclear where the EnvInjector might be useful for the public. If the need arises, we can move to the utils file or similar.
Testing
Check out on latest nightly
In the terminal, if currently unset, set
DUNEDAQ_ERS_WARNINGto be any random string (anything works, if you need inspiration try 'bippityboppityboo')Run
daqpytools-logging-demonstrator -r -eh -hcSee that both the handlerconf and the ers handler test behave as expected
When back in the terminal, try echoing the previously set variable. It should remain as whatever you set it as.
(I'm pretty sure this isnt needed, as shown in the discussion in the linked issue, but eh why not include it)
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))