Minor changes to dfmodules integtests#484
Merged
bieryAtFnal merged 5 commits intodevelopfrom Mar 26, 2026
Merged
Conversation
added 5 commits
March 25, 2026 10:05
…meSlice in the generated TPStream files in the max_file_size_test.py integtest.
…edirects to the global bundle script (dunedaq_integtest_bundle.sh) [but still focusses on the dfmodules tests].
…several integtests
…_file_size_test.py
andrewmogan
approved these changes
Mar 26, 2026
Contributor
andrewmogan
left a comment
There was a problem hiding this comment.
The changes all make sense and the tests work as stated. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes in this PR are for
fddaq-v5.7.0.There are several small changes in this PR:
max_file_size_testproduces a TPStream data file in which the last TimeSlice does not have the full number of expected fragments. This is not a big deal, so the test conditions were modified to allow the last TimeSlice to have slightly fewer fragments.max_file_size_testwas updated to make use of the newest ResourceValidation utility in theintegrationtestrepo. This has several advantages, including centralized reporting of insufficient resources and support for recommended resources in addition to required resources.dfmodules_integtest_bundle.shscript was modified to call out to the global bundle script (dunedaq_integtest_bundle.shin thedaqsystemtestrepo). This is part of moving away from repo-specific bundle scripts.data_rate_slowdown_factorparameter were removed.Here are sample instructions for validating several of these changes:
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)