Draft
Conversation
Collaborator
Author
|
TODOs
|
Collaborator
Author
|
This is working as intended and MSQT passes. Will run the full test after @mroda88 approval |
13 tasks
mroda88
approved these changes
Mar 5, 2026
Contributor
mroda88
left a comment
There was a problem hiding this comment.
Looks good to me and it works well for give an idea to the other WGs
Collaborator
Author
|
Converted to draft as the scope is unclear as of right now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #756
This PR implements a parsing of the configuration file to determine the set of resources requested for a particular session. A dummy resource manager configuration has been added to
config/tests/one-controller-config.data.xmlto validate that this is working as intended.Requirements
Manual testing suggestions
Run the changed config and validate that the requested resources are indeed parsed out of the configuraiton
Test the change without a defined set of resources
Test the change with a defined set of resources
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: [Feature]: Unit tests for unified shell #787)