Skip to content

Added capture of the run control console output so that it can be used for validations#151

Merged
bieryAtFnal merged 4 commits intodevelopfrom
kbiery/temp_branch_drunc_output_capture
Mar 25, 2026
Merged

Added capture of the run control console output so that it can be used for validations#151
bieryAtFnal merged 4 commits intodevelopfrom
kbiery/temp_branch_drunc_output_capture

Conversation

@bieryAtFnal
Copy link
Copy Markdown
Contributor

@bieryAtFnal bieryAtFnal commented Mar 25, 2026

Description

Recently, Emir asked if the console output from drunc could be captured and made available to our integtest validation checks. This PR contains the first version of code to do that. The console output continues to be printed out in real time, and it is now available in the completed_process.stdout attribute of the result of the run_dunerc fixture. This is available in our tests as run_dunerc.completed_process.stdout.

We have tested this by installing this branch of integrationtest in a local software area and verifying that all of the usual regression tests work as before.

The target release for these changes is fddaq-v5.7.0.

Type of change

  • New feature or enhancement (non-breaking change which adds functionality)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

@bieryAtFnal bieryAtFnal requested a review from emmuhamm March 25, 2026 13:53
Copy link
Copy Markdown

@emmuhamm emmuhamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kurt, thanks for this. I've looked through the code and I don't have any comments on my side.

I've also checked out the latest version of this branch (with mainly new comments) and confirmed that they do what we needed them to. The new integtests developed for drunc works as expected.

I've approved this now, feel free to merge whenever. Thanks!

@bieryAtFnal bieryAtFnal merged commit 757b7f2 into develop Mar 25, 2026
1 check passed
@bieryAtFnal bieryAtFnal deleted the kbiery/temp_branch_drunc_output_capture branch March 25, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants