Added capture of the run control console output so that it can be used for validations#151
Merged
bieryAtFnal merged 4 commits intodevelopfrom Mar 25, 2026
Merged
Conversation
added 4 commits
March 12, 2026 14:56
… pass it back to our pytest modules (integtests).
…_drunc_output_capture
…n our validation checking.
emmuhamm
approved these changes
Mar 25, 2026
emmuhamm
left a comment
There was a problem hiding this comment.
Hi Kurt, thanks for this. I've looked through the code and I don't have any comments on my side.
I've also checked out the latest version of this branch (with mainly new comments) and confirmed that they do what we needed them to. The new integtests developed for drunc works as expected.
I've approved this now, feel free to merge whenever. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recently, Emir asked if the console output from
drunccould be captured and made available to our integtest validation checks. This PR contains the first version of code to do that. The console output continues to be printed out in real time, and it is now available in thecompleted_process.stdoutattribute of the result of therun_dunercfixture. This is available in our tests asrun_dunerc.completed_process.stdout.We have tested this by installing this branch of
integrationtestin a local software area and verifying that all of the usual regression tests work as before.The target release for these changes is
fddaq-v5.7.0.Type of change
Testing checklist
dunedaq_integtest_bundle.sh)Further checks