Conversation
This updates random simulation to use centralized mandatory/optional option matching, enforces mutual exclusivity for -RST/-RST_N/-Continue, and adds persistent continue-state handling with clear runtime error messages so failures are no longer silent.
Homebrew removed the Homebrew/bundle tap, so the workflow now runs brew bundle directly against the repository Brewfile.
Set CMAKE_POLICY_VERSION_MINIMUM to 3.5 so legacy cmake_minimum_required in the glucose dependency does not abort configuration on GitHub Actions macOS runners.
Only append --sysroot to ABC CC/CXX on macOS with a valid CMAKE_OSX_SYSROOT so Linux builds no longer pass an empty --sysroot that breaks depends.sh and compilation.
Ensure C-based external projects receive a valid compiler even when the top-level project is configured as CXX-only, preventing engine-abc CI failures on Linux and macOS. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates random simulation to use centralized mandatory/optional option matching, enforces mutual exclusivity for -RST/-RST_N/-Continue, and adds persistent continue-state handling with clear runtime error messages so failures are no longer silent.