Skip to content

🔒 Fix insecure random number generator for Request ID #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaTiC0 merged 4 commits into from
Mar 12, 2026
Merged

🔒 Fix insecure random number generator for Request ID #106

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0260041
Use cryptographically secure RNG for Request ID
google-labs-jules[bot] Mar 12, 2026
f06d826
Use cryptographically secure RNG for Request ID
google-labs-jules[bot] Mar 12, 2026
ad773d0
Simplify mathematical expression for readability
google-labs-jules[bot] Mar 12, 2026
49e5f6e
Move import secrets to top of file
google-labs-jules[bot] Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions action_devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import json
import logging
import requests
import secrets
from flask import current_app
from notifications import mqtt

Expand Down Expand Up @@ -316,8 +317,8 @@ def report_state():
if not REPORTSTATE_AVAILABLE:
logger.warning("ReportState module not available, skipping report_state")
return "ReportState not available"
import random
n = random.randint(10**19, 10**20)

n = 10**19 + secrets.randbelow(9 * 10**19 + 1)
report_state_file = {
'requestId': str(n),
'agentUserId': current_app.config['AGENT_USER_ID'],
Expand Down
Loading