Skip to content

Conversation

@slipher
Copy link
Member

@slipher slipher commented Jan 16, 2026

Fixes #1628

Multiply the pixel color by r_toneMappingExposure even when tone mapping
is disabled. For the next release the cvar should be renamed to reflect
its separation from tone mapping.

Fixes DaemonEngine#1628.
since it can now be used without tone mapping.
@VReaperV
Copy link
Contributor

Rename u_TonemapExposure -> u_Exposure

That seems like it can break configs if someone e. g. used it in autoexec.cfg. Is the renaming really necessary?

@illwieckz
Copy link
Member

Rename u_TonemapExposure -> u_Exposure

That seems like it can break configs if someone e. g. used it in autoexec.cfg. Is the renaming really necessary?

This renames the internal variable, not the r_toneMappingExposure cvar.

@VReaperV
Copy link
Contributor

Rename u_TonemapExposure -> u_Exposure

That seems like it can break configs if someone e. g. used it in autoexec.cfg. Is the renaming really necessary?

This renames the internal variable, not the r_toneMappingExposure cvar.

The comment says:

// TODO(0.56): rename because it can be used without tone mapping now

@illwieckz
Copy link
Member

illwieckz commented Jan 16, 2026

Ah yes. The sentence you quoted didn't mention that, and the currently proposed code doesn't do that yet.

To be honest I'm in favor of the renaming of the cvar. We are still in beta and if every first implementation is written in stone and we cannot use our experience and testing to make it better it becomes hard to do things.

As a side note I would like to have a cvar alias mechanism so using an old name sets the new cvar, but we haven't that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make rendering "exposure" available without tone mapping?

3 participants