Skip to content

fix(deploy): remove stale container before recreate + fix hadolint CI on ARM (DAK-6541) #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ferhimedamine merged 3 commits into from
Jun 12, 2026
Merged

fix(deploy): remove stale container before recreate + fix hadolint CI on ARM (DAK-6541) #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fb3e56
fix(deploy): remove stale container before recreate to prevent naming…
ferhimedamine Jun 12, 2026
71646fe
fix(ci): add GHCR login before hadolint on self-hosted ARM runner
ferhimedamine Jun 12, 2026
cd3257b
fix(ci): run Dockerfile validation on GitHub-hosted runner
ferhimedamine Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ permissions:
jobs:
validate:
name: Validate Docker Configs
runs-on: [self-hosted, linux, arm64]
# GitHub-hosted: hadolint-action pulls ghcr.io/hadolint/hadolint which needs
# authenticated GHCR access; GitHub-hosted runners have ambient auth, self-hosted ARM do not.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/deploy-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ jobs:
COMPOSE_DIR=$(docker inspect "$CONTAINER" --format '{{ index .Config.Labels "com.docker.compose.project.working_dir" }}' 2>/dev/null || echo "")
if [ -n "$COMPOSE_DIR" ] && [ -d "$COMPOSE_DIR" ]; then
cd "$COMPOSE_DIR"
# Remove stale container before recreate to prevent Docker naming conflicts
# (container_name + compose project-hash alias can collide on --force-recreate)
docker rm -f dakera 2>/dev/null || true
# Force-recreate minio so new resource limits (cpus/memory) take effect
DAKERA_IMAGE=ghcr.io/dakera-ai/dakera:${{ inputs.version }} docker compose up -d --force-recreate minio minio-setup dakera
else
Expand Down