feat: add T-I-F reliability helpers (TifScore, EvaluateTif)#106
Conversation
Implements Phase 3 of the T-I-F RFC (dakera-deploy#161). - Add TifScore struct, TifClassification constants, ComputeTifScore() and TifScoreFromMetadata() helpers to types.go - Add EvaluateTif() method to Client in client.go - Add 12 unit tests in tif_test.go covering all edge cases Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Document TifScore struct, FromFeedbackHistory, FromMetadata, and EvaluateTif() in CHANGELOG [Unreleased] and README feature list. Part of T-I-F RFC Phase 3 (DAK-6562).
|
Phase 3 SDK review note from the RFC side. The Go API direction is right: I would keep this draft blocked for two reasons:
Suggested acceptance gate: add shared golden vectors across Python/JS/Rust/Go/MCP and verify the exact same Once the conflict is resolved, checks are green, and parity is locked, this should be a good Go-side Phase 3 helper. |
919ea07 to
636c085
Compare
…6566) Aligns Go SDK with MCP canonical T-I-F v1 contract: - Inject base indeterminacy when feedback_count < 3 to prevent false confidence from sparse signals - Normalise T+I+F to 1.0 after adding base indeterminacy - Add 8 golden vector tests matching MCP/Python/JS/Rust - Add 3 thin-evidence unit tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@ferhimedamine final Phase 3 review complete from my side for the Go SDK PR. I rechecked the current PR state and the DAK-6566 parity fixes. The previous blockers are resolved:
This is review-ready from my side. No further requested changes from me. |
Summary
Part of T-I-F RFC Phase 3 — adds type-safe T-I-F reliability helpers.
Changes:
TifScorestruct andTifClassificationstring constants intypes.goComputeTifScore(*FeedbackHistoryResponse) TifScorefunctionTifScoreFromMetadata(map[string]interface{}) (TifScore, bool)functionEvaluateTif(ctx, memoryID)method onClientinclient.gotif_test.goGo idioms: Uses string-typed
TifClassificationwith named constants (TifConfidentReuse, etc.) following existingFeedbackSignalpattern in the codebase.🤖 Generated with Claude Code
Reviewed-by: Jean-Sébastien Beaulieu (@SeCuReDmE-main-dev) — T-I-F contract parity review