feat: Enable more flexible Secret root dir behavior.#6
Merged
Conversation
0918d71 to
4ad38ac
Compare
62c84be to
930b4b8
Compare
|
hi, any chance to marge it? |
Owner
Author
|
i definitely forgot about this, sorry! I can take at rebasing and making sure the strat makes sense tomorrow morning hopefully |
930b4b8 to
bfab69b
Compare
Owner
Author
loader = Secret.load_with(dir="whatever")
# or
loader = Secret.load_with(dir=("whatever", "else"))
load_settings(Settings, extra_loaders=loader)would be the interface this pr lands on.
If you could test the PR before I merge, that'd be ideal. to make sure it addresses the OP |
bfab69b to
8e24a20
Compare
8e24a20 to
51f88d1
Compare
|
|
|
Looks great, seems working 👍 |
|
BTW, it's easier to review changes when changing the code and moving it between files is done in separate commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5