Fix canonical timezones for web#77
Open
tigloo wants to merge 2 commits into
Open
Conversation
* Update hardcoded path to include assets/ dir * Include assets directly in package so they are shipped automatically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS 14 will report the time zone as "CET" instead of for example "Europe/Berlin". This breaks at least Flutter Web clients because time_machine is unable to identify the local timezone during initialization.
This patch adds a couple of those definitions to tzdb.json. (which won't fix lookup in tzdb.bin, not sure if the same problem exists there)
I originally tried to patch up the tzdb compiler but too much was broken there.
Note that this PR includes the changes of #76. The changes can be decoupled from each other though.