This repository was archived by the owner on Apr 25, 2020. It is now read-only.
Basic idea for outputting proper datatypes (mock interface)#845
Open
Basic idea for outputting proper datatypes (mock interface)#845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a pretty barebones implementation of what I had in mind in #823, more or less.
Admittedly, didn't think too much about structure, but long story short I wanted to have at least a theoretical ability to have multiple output formats, hence
OutputFormatdatatype.*OutputConfigshould allow us to move things like--detailfrom actual library implementation to output format implementation (since, you know, library functions shouldn't have to format output, I would assume in most cases we'd like to dump all information we can to consumer) -- for now onlyNoOutputConfigis there.Let me know if you'll think of improving this somehow. I won't be able to work on this much in the next ten days or so.