Refactor duplicated code in transmission channels and bandwidth metrics

[Copilot]

Identified and eliminated ~210 lines of duplicated code across transmission channels and metrics classes.

Changes

Transmission Channels

• Moved AddMessageToSend(), GetReadyToProcessMessage(), and ArePendingReadyToProcessMessages() to TransmissionChannel base class
• Added pure virtual IsMessageSuitable() to enable base implementation
• Removed ~60 lines of duplication across ReliableOrderedChannel, UnreliableOrderedTransmissionChannel, and UnreliableUnorderedTransmissionChannel

Bandwidth Metrics

• Created BandwidthMetric base class consolidating common logic
• Reduced UploadBandwidthMetric and DownloadBandwidthMetric from 86 lines to 12 lines each
• Metrics now differ only in GetName() override

Before:

class UploadBandwidthMetric : public IMetric {
    // 86 lines of implementation including:
    // - Constructor initializing 5 member variables
    // - GetValue(), SetUpdateRate(), Update(), AddValueSample(), Reset()
    // - 5 private member variables
};

class DownloadBandwidthMetric : public IMetric {
    // 86 identical lines (only GetName() differs)
};

After:

class BandwidthMetric : public IMetric {
    // Common implementation (75 lines)
protected:
    float32 _updateRate, _timeUntilNextUpdate;
    uint32 _inProgressValue, _currentValue, _maxValue;
};

class UploadBandwidthMetric : public BandwidthMetric {
    void GetName(std::string& out) const override {
        out.assign(UPLOAD_BANDWIDTH_METRIC);
    }
};

class DownloadBandwidthMetric : public BandwidthMetric {
    void GetName(std::string& out) const override {
        out.assign(DOWNLOAD_BANDWIDTH_METRIC);
    }
};

Build

• Fixed premake5.lua case sensitivity for Linux (common/ → Common/)
• Added Makefile patterns to .gitignore

Original prompt

Find and refactor duplicated code

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.