1-73-1#272
Conversation
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull request overview
Fixes the MTProto DC Relay socat helper to generate working forwarding commands by targeting Telegram’s public DC TCP endpoints (rather than the internal middle-proxy backends returned by getProxyConfig), and removes the unnecessary command for media DC 203 (which reuses DC2’s relay port).
Changes:
- Add a backend-provided
directDC endpoint map and include it in/mtproto/refresh-dcsresponses. - Update the UI helper dialog to prefer
directendpoints and to omit DC203from the generated relay-port mappings. - Update EN/RU docs and changelogs to reflect the corrected relay behavior and firewall port count (5 ports).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/mtproto/dc.go | Adds DirectAddresses() to expose public DC TCP endpoints for the UI helper. |
| src/http/handler/mtproto.go | Extends refresh response with direct endpoints. |
| src/http/ui/src/components/settings/MTProto.tsx | Extends refresh result typing and plumbing to carry direct. |
| src/http/ui/src/components/settings/MTProtoRelayHelpDialog.tsx | Builds socat mappings from direct endpoints and omits DC 203. |
| docs/docs/mtproto.md | Updates relay helper documentation (no media DC command; 5 firewall ports). |
| docs/i18n/ru/docusaurus-plugin-content-docs/current/mtproto.md | Same as above for RU docs. |
| changelog.md | Adds 1.73.1 entry describing the fix. |
| changelog_ru.md | Adds 1.73.1 RU entry describing the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const mappings = useMemo(() => { | ||
| if (!relayInfo || !refreshResult?.ok) return []; | ||
| return Object.entries(refreshResult.dcs) | ||
| const addrs = refreshResult.direct ?? refreshResult.dcs; | ||
| return Object.entries(addrs) | ||
| .map(([id, addr]) => { |
No description provided.